staking-async runtime: extended duration of the signed phase#8870
Merged
staking-async runtime: extended duration of the signed phase#8870
Conversation
For the staking-async test runtime, extended the duration of the signed phase from 2 to 4 minutes, in order to give enough time to the staking miner to mine, submit the score and all pages during the signed phase itself. While testing on CI / locally for a 32-page solution, the miner ends up submitting pages pretty close to the end of the signed phase itself. Whereas this is a valuable scenario to test to prove miner's robustness, in the main happy path we want the miner to have enough time to submit the whole solution and to be able to handle a re-tx if one/N pages fail to be submitted still within the same Signed phase cycle.
sigurpol
added
the
R0-no-crate-publish-required
sigurpol
requested review from
a team,
kianenigma and
seadanda
and removed request for
a team
seadanda
approved these changes
Jun 17, 2025
kianenigma
approved these changes
Jun 17, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
For the staking-async test runtime, we extend the duration of the signed phase from 2 to 4 minutes, in order to give enough time to the staking miner to mine, submit the score, verify it's on chain and then submit all pages during the signed phase. While testing on CI / locally for a 32-page solution, the miner ends up submitting pages pretty close to the end of the signed phase itself. Whereas this is a valuable scenario to test to prove miner's robustness, in the main happy path and while testing locally, we want the miner by default to have enough time to submit the whole solution and to be able to handle a re-tx if one/N pages fail to be submitted still within the same Signed phase cycle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the staking-async test runtime, we extend the duration of the signed phase from 2 to 4 minutes, in order to give enough time to the staking miner to mine, submit the score, verify it's on chain and then submit all pages during the signed phase.
While testing on CI / locally for a 32-page solution, the miner ends up submitting pages pretty close to the end of the signed phase itself.
Whereas this is a valuable scenario to test to prove miner's robustness, in the main happy path and while testing locally, we want the miner by default to have enough time to submit the whole solution and to be able to handle a re-tx if one/N pages fail to be submitted still within the same Signed phase cycle.